fixes for c++ error on missing enum cast and warning on MlKemKey init#928
Merged
ejohnstown merged 2 commits intowolfSSL:masterfrom Apr 17, 2026
Merged
fixes for c++ error on missing enum cast and warning on MlKemKey init#928ejohnstown merged 2 commits intowolfSSL:masterfrom
ejohnstown merged 2 commits intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes C++ build issues in the ML-KEM hybrid key exchange paths by addressing enum type mismatches and initialization warnings.
Changes:
- Replace
MlKemKey kem = {0};with explicitWMEMSET(&kem, 0, sizeof(kem));to avoid C++ aggregate-init warnings. - Add explicit casts to
(enum wc_HashType)forwc_HashGetDigestSize()andwc_Hash()calls to satisfy C++ enum typing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ejohnstown
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.